Skip to content

Returning largest of two scores#542

Merged
joanreyero merged 1 commit into
mainfrom
bugfix/merge-members-largest-score
Feb 20, 2023
Merged

Returning largest of two scores#542
joanreyero merged 1 commit into
mainfrom
bugfix/merge-members-largest-score

Conversation

@joanreyero
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero commented Feb 16, 2023

Changes proposed ✍️

  • When merging members, return the largest of the two scores.

This is still not 100% correct. Ideally we should recompute the score, but it will happen within 1 hour anyway.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanreyero joanreyero added the Bug Created by Linear-GitHub Sync label Feb 16, 2023
@joanreyero joanreyero requested a review from epipav February 16, 2023 13:30
@joanreyero joanreyero marked this pull request as ready for review February 16, 2023 13:30
@joanreyero joanreyero merged commit c78c65d into main Feb 20, 2023
@joanreyero joanreyero deleted the bugfix/merge-members-largest-score branch February 20, 2023 09:01
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants